moeffju.net

WordPress 2.1-alpha3 and Ultimate Tag Warrior

25 Dec, 06

If you’re running WordPress 2.1 trunk from SVN (currently at 2.1-alpha3, r4663) with Ultimate Tag Warrior (UTW) 3.141592 (the latest version as of today), UTW will lose all tags on a post when a new comment is made.

To fix this, edit the ultimate-tag-warrior-actions*.php files (in your UTW directory, there should be one -actions.php and one -actions-wordpress2.php, simply edit both). In the function ultimate_save_tags($postID), add the following lines right after the opening curly bracket:

    if (!is_admin()) return $postID;
    if (!isset($_POST['tagset'])) return $postID;

Save the files and you should be all set.

The problem occurs because WordPress trunk calls the edit_post hook when new comments are added. UTW doesn’t check the environment and just assumes the admin wanted to delete all tags, and then dutifully removes the tags from the post.

The fix just does nothing when the edit_post hook gets called from outside the admin publish area.

Update: See also Thomas’ comment for the latest UTW version.

Feed for this entry

33 Comments

tags , , and

Comments

  1. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment928]

    Thanks, this was a real lifesaver :)

    by ketsugi on Jan 9, 2007 @ 02:59am

  2. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment933]

    […] Je?li kto? u?ywa WordPress’a 2.1 alpha3/beta1 i Ultimate Tag Warriora 3 to zapewnie zauwa?y?, ?e znikaj? tagi dla wpisu po dodaniu komentarza do niego. Jak to naprawi?? Ano w bardzo prosty sposób opisany tutaj. […]

    by UTW3 i WordPress 2.1 at simply zimaq on Jan 16, 2007 @ 01:32am

  3. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment935]

    […] fix has just been released, recommended to update now! Bugs, Technorati Tags, Ultimate Tag Warrior, WordPressShare This […]

    by Ultimate Tag Warrior and WordPress 2.1 at The NeoSmart Files on Jan 18, 2007 @ 05:28pm

  4. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment926]

    […] Ultimate Tag Warrior 3 spraudnis ir sal?zis - pievienojot ierakstam jaunu koment?ru, paz?d tagi. Risin?jums šeit. […]

    by WordPress 2.1 at the brand with the four stripes on Jan 23, 2007 @ 03:06pm

  5. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment924]

    […] das neueste Wordpress mit dem Plugin UTW nicht richtig funktionieren soll, gibt es auf moeffju.net einen UTW Hack. Für all diejenigen, die unbeding updaten möchten, aber UTW einsetzen […]

    by Basic Thinking Blog » Wordpress 2.1 und Ultimate Tag Warrior on Jan 24, 2007 @ 12:06pm

  6. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment923]

    […] …it could be worse… WordPress 2.1 And Ultimate Tag Warrior Fix Just in case you didn’t know. For whatever reason, Matthias Bauer can explain it better, UTW&#… […]

    by WordPress 2.1 And Ultimate Tag Warrior Fix on Jan 24, 2007 @ 04:24pm

  7. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment922]

    […] UTW-Plugin laufen dazu alle Erweiterungen fehlerfrei: wer selbst Hand anlegen will, kann mit diesem Hack auch dem Ultimate Tag Warrior auf die Sprünge helfen. Und wo wir gerade bei neuen Versionen sind: […]

    by Operation erfolgreich: Wordpress 2.1 running at Maveriksworld.de on Jan 25, 2007 @ 12:28am

  8. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment921]

    […] hatte wohl arge Probleme, die zum Verlust der Tags führten! Mehr dazu etwa bei moeffju.net, dessen Hack ich aber nicht einspielen/-bauen […]

    by who ever this concerns … » Blog Archiv » Upgrade auf WordPress 2.1 reibungslos on Jan 26, 2007 @ 06:46am

  9. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment919]

    Thanks a lot for this fix! Like many others, it has saved me from further problems with losing tags. Keep up the good work mate! :)

    by Jaypee on Jan 28, 2007 @ 04:48pm

  10. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment920]

    […] the meantime, if you’re also a victim of this don’t fret. Moeffju has a manual fix for it. Below is the steps on how to do […]

    by Ultimate Tag Warrior + WP 2.1 = Lost Tags » JaypeeOnline on Jan 28, 2007 @ 04:48pm

  11. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment918]

    […] habe ich diesen Tipp übrigens hier. Tags: altmetall, baustelle, blog, technik, […]

    by Altmetall » Upgrade erledigt on Jan 29, 2007 @ 03:48pm

  12. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment929]

    […] of my plugins caused broken pages/categories, but I have updated them- especially a quick fix from Moeffju.net for Ultimate Tag Warrior- see end of post). Mostly took longer due to my FTP connection, and the […]

    by Fox Haven Journal » Blog Archive » Upgrade Tips for WordPress 2.1 “Ella” on Jan 29, 2007 @ 11:21pm

  13. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment936]

    […] good news is, there is a fix published on moeffju.net. Tags:moeffju.net, Ultimate Tag Warrior, […]

    by Mark Blevis » Ultimate Tag Warrior tags vanish in WordPress 2.1 on Jan 31, 2007 @ 12:10pm

  14. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment938]

    After this fix, will the tags still be deleted after a moderated comment is approved?

    by karrie on Jan 31, 2007 @ 07:06pm

  15. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment939]

    karrie - after you applied the fix, the problem would be solved. I’ve also had the problem and did this fix and after that my tags stayed in place. Hehe :D

    by Jaypee on Jan 31, 2007 @ 07:11pm

  16. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment940]

    WordPress 2.1 Ella issues…

    Just a quick list of some issues I experienced after I upgraded to WordPress 2.1 Ella:

    Insert a link/image into your post won’t work: can old cached version of the Rich Text Editor’s JavaScript file causes the problem. Clear your browser c…

    by Christian Spanring's Blog on Jan 31, 2007 @ 09:01pm

  17. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment941]

    This breaks the UTW fix for ecto publishing via xmlrpc :-)

    http://www.robinlu.com/blog/archives/86/

    here

    by bruno afonso on Jan 31, 2007 @ 09:22pm

  18. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment942]

    bruno, with the changes described in http://www.robinlu.com/blog/archives/57, it should work since $_POST[‘tagset’] is set. Or does is_admin return false for xmlrpc requests? In the latter case, I can’t think of a simple fix except maybe a define() in xmlrpc.php; if you just remove the is_admin check, anyone can modify the tagset to any post if they can comment on it.

    by moeffju on Feb 1, 2007 @ 12:20am

  19. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment944]

    In the latest UTW-Version (Ultimate Tag Warrior 3.1415926) you have only the file ultimate-tag-warrior-actions.php. -wordpress2.php does no longer exist. And only if you aprove a comment you will lost your tags.
    I tried this (from Christines posting):
    if (isset($_POST['not_spam'])) return $postID; // akismet fix if (isset($_POST["comment"])) return $postID; // moderation.php fix
    and the code from 082net (it’s above your comment)
    // Save changes to tags add_action('save_post', array('UltimateTagWarriorActions','ultimate_save_tags')); if($wp_db_version < 3308 ) { // if lesser than WP 2.0 add_action('publish_post', array('UltimateTagWarriorActions','ultimate_save_tags')); add_action('edit_post', array('UltimateTagWarriorActions','ultimate_save_tags')); add_action('wp_insert_post', array('UltimateTagWarriorActions','ultimate_save_tags'));} add_action('delete_post', array('UltimateTagWarriorActions', 'ultimate_delete_post'));
    All this together fix the problem.
    This works also with ecto-patch

    by Thomas on Feb 2, 2007 @ 03:48pm

  20. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment945]

    @Thomas:

    if (!isset($_POST['tagset'])) return $postID; should work for all cases, including comment moderation. Did it not work for you?

    by moeffju on Feb 2, 2007 @ 04:04pm

  21. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment934]

    Yes,
    I tried only this - but with the hook-changes at the end of the file. Without the hook-changes it doesn’t work.

    by Thomas on Feb 2, 2007 @ 04:21pm

  22. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment932]

    […] plugins known/not-known to work and of course the code-edits to get Ultimate Tag Warrior to work @ this site. Following all the instructions actually worked without a hitch! Its only been 20 minutes since I […]

    by This blog has just gone thru major surgery! on Feb 3, 2007 @ 07:46pm

  23. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment930]

    […] whenever a new comment was being posted or when you try to edit the post. Fortunately, there is a cool fix available till a new release of UTW comes out. Article printed from Null Pointer: […]

    by Null Pointer » WP 2.1 upgrade irks UTW on Feb 4, 2007 @ 08:09am

  24. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment931]

    […] ?????? ???? ???? ?? ?? ??? ??? ?? UTW ?? ???? ?? ?? ??? ????? ?? ???? ?? ?? ??????? ?? […]

    by ????????? 2.1 ?? ??? ?????? ?? ???? at ?????????? on Feb 4, 2007 @ 08:59am

  25. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment946]

    […] corregir el bug en Ultimate Tag Warrior 3.14592 (lo encontré aquí) deberemos modificar la función ultimate_save_tags($postID) de los ficheros […]

    by El blog de nico » Blog Archive » Fallo de plugins con Wordpress 2.1 on Feb 5, 2007 @ 11:10am

  26. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment927]

    […] WordPress 2.1-alpha3 and Ultimate Tag Warrior « moeffju.net (tags: plugin wordpress bug tag hack) Tag: […]

    by Livingston, il blog di Marco Mazzei / links for 2007-02-07 on Feb 7, 2007 @ 12:20pm

  27. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment925]

    […] problem at moeffju.net’s blog. If you are using the latest version of UTW, you will want to read the comment provided by […]

    by Empowering the Next Idea ... · WordPress 2.1 and Ultimate Tag Warrior Fix on Feb 7, 2007 @ 05:53pm

  28. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment947]

    […] Googled for a fix to see if others may be experiencing the same issue and discovered a WordPress 2.1 and Ultimate Tag Warrior fix at moeffju.net’s weblog.  If you are facing the same dilemma, do not worry, I recommend […]

    by Empowering the Next Idea ... · WordPress 2.1 and Ultimate Tag Warrior Fix on Feb 7, 2007 @ 08:39pm

  29. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment948]

    […] you are using the latest version of Ultimate Tag Warrior (UTW version 3.1415926) you will want to read a comment by Thomas for expanded details on updating. 1 comment Comments feed for this article Trackback […]

    by Empowering the Next Idea ... · WordPress 2.1 and Ultimate Tag Warrior Fix on Feb 7, 2007 @ 08:56pm

  30. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment943]

    […] when used in Wordpress 2.1 - posting comments caused a post’s avatar to disappear. Thanks to moeffju.net I’ve identified and fixed (yay!) the […]

    by Post Avatar 1.2.2 - Garinungkadol on Feb 12, 2007 @ 02:59am

  31. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment937]

    Doesn’t work with 2.1.2. Spent hours on this, need to figure out if xmlrpc.php needs yet another tweak to work with Ecto.

    by David Evans on Mar 6, 2007 @ 11:35pm

  32. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment949]

    […] ??????????????Gaame ??? 2.1 ?????????????????????????? post ? tag ??????????????? N ?????????????? ???????????????????? […]

    by sein » UTW ? wp 2.1 ????? tag ??? on Mar 30, 2007 @ 03:49pm

  33. [wordpress-21-alpha3-and-ultimate-tag-warrior#comment968]

    […] Basic mal wieder etwas gelernt. Nämlich, dass das an der UTW Version liegt. Nach der Update auf die aktuelle Version ging doch tatsächlich alles wieder … tags:firefox 1.5, gut gegangen, upgrade, […]

    by zuckerbrot » Blog Archive » wordpress 2.2.1 de Edition on Jun 28, 2007 @ 04:39pm